FIO-8537: Fixing the filter processor to handle nested component data properly. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnformio
approved these changes
Jul 16, 2024
lane-formio
pushed a commit
that referenced
this pull request
Jul 30, 2024
… properly. (#117) * FIO-8537: Fixing issues with the filter process to handle nested components properly. * Adding the process tests to test for proper filtering of nested components. * Removed a non-implemented test. * Adding a new line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8537
Description
Previously, we were not setting the "initial" value of the nested data components to an empty object in the filtered object. Because of this, values that should not be there were not being properly filtered away in the "additive" process that the filter system uses to create a "clean" object.
This change ensures that all the nested values are "clean" from the start, and then as the processor iterates through the children, their values are set on the filtered object inside the cleaned object.
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
Use this section to list any dependent changes/PRs in other Form.io modules
How has this PR been tested?
Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning
Checklist: